restruct parsing flow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngocthanh1389
force-pushed
the
TRD-485-match-exchange-with-address
branch
from
eba2b26 to
22bcd64
Compare
secmask
reviewed
Aug 7, 2024
| @@ -87,14 +81,19 @@ func (w *Worker) processMessages(m []evmlistenerclient.Message) error { | |||
| } | |||
| } | |||
| for _, log := range block.Logs { | |||
| if len(log.Topics) == 0 { | |||
| continue | |||
| ethLog := convert.ToETHLog(log) | |||
There was a problem hiding this comment.
I think should refactor this block into something like findMatchingParser
secmask
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
Currently, we identify exchange by event log
So, with contract don't have event log like 0x v3, we can't parse trade
What do you do?
We verify exchange base on contract address also
Remove unused exchange and add 0x v3